You are viewing a single comment's thread from:
RE: StemQ beneficiaries development
Thank you for your contribution @irelandscape
- A few places where you could replace
let
withconst
- You may want to use
steem.utils.validateAccountName
to validate the user name instead of.acount.length >= 4
. onOK
andmouted
are empty, do we really need them?- do we really need
this.form.beneficiaries = [...this.form.beneficiaries]
? - is there a chance that
max
could be negative? - a few more comments would be nice
- maybe you can refactor and extract the logics to a few functions/modules so that you can unit test them.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review, @justyy! Keep up the good work!