You are viewing a single comment's thread from:

RE: StemQ beneficiaries development

in #utopian-io6 years ago

Thank you for your contribution @irelandscape

  1. A few places where you could replace let with const
  2. You may want to use steem.utils.validateAccountName to validate the user name instead of .acount.length >= 4.
  3. onOK and mouted are empty, do we really need them?
  4. do we really need this.form.beneficiaries = [...this.form.beneficiaries]?
  5. is there a chance that max could be negative?
  6. a few more comments would be nice
  7. maybe you can refactor and extract the logics to a few functions/modules so that you can unit test them.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.20
TRX 0.26
JST 0.040
BTC 101672.76
ETH 3666.48
USDT 1.00
SBD 3.15