[Development] Fix issue on steemhunt/web where using symbols other than @ before a username makes a mention invalid
Repository
https://github.com/Steemhunt/web
Pull Request
Bug Fixes
- What was the issue(s)?
- Fix issue #220 being reported by @sourovafrin
- Using symbols other than @ before a username makes a mention invalid.
Issue reported by sourovafrin
- What was the solution?
- Inspect the code different between how steemit parsed markdown to fix the issue based on this 2 files:
https://github.com/steemit/condenser/blob/master/src/shared/HtmlReady.js
and https://github.com/steemit/condenser/blob/master/src/shared/HtmlReady.test.js - Write a test to test whether the code works. (changes some code from steemit in order to pass the test)
- Inspect the code different between how steemit parsed markdown to fix the issue based on this 2 files:
tagging username works properly after the fix
About Steemhunt
What is the project about?
Steemhunt is a Steem blockchain powered ranking community for geeks, alpha nerds, and product enthusiasts who love to dig out new products and talk about them with others.
Technology Stack
React, Redux, AntDesign, ScssHow to contribute?
Steemhunt has their own repository at https://github.com/steemhunt. I had written a guide on how to run SteemHunt website on your own computer
Thanks for the contribution, superoo7! Cool to see you working on SteemHunt's website, have you contributed to it before?
Although it's a small change, it's great you included tests for it as well - great work!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thanks for moderating. I had contributed a few on June this year actually, check the contributors from github hehe.
https://github.com/Steemhunt/web/graphs/contributors
https://github.com/Steemhunt/api/graphs/contributors
Thank you for your review, @amosbastian!
So far this week you've reviewed 1 contributions. Keep up the good work!
Hi, @superoo7!
You just got a 5.3% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
Hi @superoo7!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
你那里天气如何？还在发愁自己的好文没人发现，收益惨淡吗？记得加上cn-curation标签，让飞鸽传书 帮你走出困境吧！倘若你想让我隐形，请回复“取消”。
Thank you for using @entrust!
You got a 32.95% upvote from @entrust courtesy of @superoo7!
Entrust is a bot focused on rewarding delegators and helping users promote their posts. We give 100% of the total rewards to the delegators with payouts will be given daily. If you would like to consider delegating to @entrust, we've made a quick delegation link for you :
1000 SP | 500 SP | 300 SP | 200 SP | 100 SP or visit our own tracker website for more information :
You’ve been upvoted by TeamMalaysia community. Here are trending posts by other TeamMalaysia authors at http://steemit.com/trending/teammalaysia
To support the growth of TeamMalaysia Follow our upvotes by using steemauto.com and follow trail of @myach
Vote TeamMalaysia witness bitrocker2020 using this link vote for witness
Hey, @superoo7!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!