[Steemia v 0.0.5]Editing a comment to an empty comment leads to infinite loading. Preventing the user from doing anything else

rufans (68)in #utopian-io • 6 years ago (edited)

Project Information

Repository:
Steemia
Project name: Steemia
Publisher: Steemia

Expected behavior

An alert message A comment cannot be empty should pop up while trying to publish the empty edited comment.

Actual behavior

Editing a comment to an empty comment leads to infinite loading. Preventing the user from doing anything else.

How to reproduce

download the app Steemia
Sign in
Locate any post then make a comment
press-hold your comment to edit
Empty your comment ( delete everything in the box ) then click on submit.

App version: steemia 0.0.5
Operating system: android 8.1 Oreo. Tecno camon X pro

Recording Of The Bug

Solution

The below lines of code should be added to edit-comment file.

case 'EMPTY_TEXT':
       message = this.translate.instant('generic_messages.empty_message');
       break;

Githup profile

Realrufans

Issue reported on Github and confirmed by PO
Screenshot (31).png

#bug-hunting #steemia #mobile

6 years ago in #utopian-io by rufans (68)

Sort:

fego (72) 6 years ago

Hi @rufans, thanks for making this contribution.

I see the PO has confirmed this, hopefully a fix should be available before the next release. Other frontends have provision for this, the update button blurs out and becomes unclickable, it needs not return an error message.

The post title is in accordance with Utopian bug contribution guidelines. It contains clear and sufficient information.
The download and sign-in steps could have been skipped. We know you must have downloaded the app else you wouldn't have observed the buggy feature, and you ought to be signed in to make comments, obviously. Steps should be straight to the point and are to contain just relevant details.
Its great of you to have proposed a fix. However, you should point where the problem lie before drafting a solution. It is expected that you peruse the code for where the error may have originated, then point at the block of code that need correcting or improving.

I hope the feedback helps. I look forward to tour next contribution.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]