Thank you @schererf for the contribution! I believe I got to know this idea when helping translating @arcange 's post long time ago and I am glad that this is actually alive, and yet for some time.

1. You can use async/await to replace your Promise
2. You can use const or let to replace the `var.
3. It is generally not a good idea to have a large commented-out of code.
4. if (pDate === undefined || pDate === null) pDate = new Date(); could be better styled as something like pDate = pDate || (new Date) . Also the ES6 supports setting default values in the function parameter e.g. function convertToDetailedDate(pDate = new Date())
5. I expect to see some tests but couldn't find any despite that you have ng test in your readme.
6. Some of your parameters are tightly coupled with your functions you might want to define those parameters such as beneficials percentages in a JSON/XML config file. Similarly for messages you might want to localize them in a separate template file.

So... how to sell my old-goodies using steembay? is there a guide ?

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Chat with us on Discord.

[utopian-moderator]