You are viewing a single comment's thread from:
RE: User API implementation into the PHP Client for Makerlog
Thank you for your contribution.
- I think this is a bit verbose
$Makerlog->getUsers()->getUserObject('dehenne');instead, you can do$Makerlog->getUserObject('dehenne'); - Your APIs contains a few duplicate pattern, which could be refactored. For example,
getRequests(),json_decode,try .. throw - As I have always pointed out in your previous contributions, I'd like to see unit tests, which could be perfectly suitable to serve this purpose e.g. API design.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review, @justyy! Keep up the good work!