RE: [Release] Better Crowdin Darkmode - a necessary addon for translating nightowls.
Hey! You might not (or you might actually absolutely do so) believe me when I say this, but this is the first thing I ever built in JS. jQuery and Vanilla is all I know, so I use them both to best of my abilities. For now they do more than fine and jQuery came in handy when building the GUI later on, which is now working - although still WIP - and I'll be uploading it soon!
Here's a small sneak peak to get you motivated - it was really fun to build, actually.
I am often guilty of spending 30 minutes making changes without checking if they break anything in-between. I was really surprised that very few updates I made introduced more than a syntax error. I might yet fall in love with this language, I guess.
Back to your feedback though:
Is there a reason you use var instead of let and const? You could also a for...of statement statement instead.
No reason other than lack of experience. I already started using let
instead and will change the old ones as well. Will replace the loop too, thanks!
Should add a space before opening brackets, e.g. if() -> if (). I would also recommend installing ESLint, as that will help for linting (like PEP8 / pylint for Python).
Note taken, thanks!
Your feedback is amazing as always and I'm glad to say that I had coded like 3x as much in the same amount of time last night, so you'll get much more to review.