RE: [Steemia Pay] - Login Wall, lazy loading, tokenized state, and more changes
Here are a few things I noticed in your project.
API_KEY_FOR_IOS and API_KEY_FOR_ANDROID are your sure it's a good idea to have them in your repository ?
https://github.com/hsynterkr/Steemia-Pay/pull/1/files#diff-c5748cdbfaac36882ba927953843edf3R29 => May be you could iterate other an array.
https://github.com/hsynterkr/Steemia-Pay/pull/1/files#diff-a81e1bba80a67f0358bf0b7f1be20427R7 => https://img.busy.org redirects to https://steemitimages.com. You should use it directly. (You have multiple reference to https://img.busy.org)
Your scss files are a little broken regarding the code indentation.
This is really good work! You've made some great improvements
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hello @gregory.latinier,
I noticed the disclosure of the API keys. I will tell him to either change them or lock them.
Regarding images, I will change them to the original endpoint (I didn't do this change. It was originally like this). Also, most of the CSS was not done by me :D
Overall, thanks for your suggestions. I noticed that you always give detailed feedbacks and I really like it.
Hello @gregory.latinier
Good catch thank you for the trick! I will add authorization, also we will no longer use this maps library. We will use Native Google Maps.
Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.
Contributing on Utopian
Learn how to contribute on our website.
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!