You are viewing a single comment's thread from:

RE: JarvisHub - A bot to find similar issues.

I think this is a excellent idea and indeed in huge projects or projects with huge activity it would be useful.

Let's go for the review:

  • you could explain how similar issues are found and offer customization on the search criteria

  • your commits are almost perfect. Instead of writing update package.json you could write add dotenv and elasticsearch. The dev doesn't need to open the commit then because it's precise.

  • great code, all the best practices are there (I think) +1

  • what happens if I run the collector more than once ? (people don't always follow instructions like you expect)

  • How about writing some unit tests?

In overall you have a really good start. A better presentation would greatly benefit your idea/project.

Good luck for the next features!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you. You always with good reviews and feedbacks.

  • To find similar ones, I've used the More Like This for elastic search. Most of the magic is done by elastic search, but I had to make some adjustments in the query to increase the range (https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-mlt-query.html)

  • Yes Yes. I'll improve next time.

  • I'm glad you enjoyed it, but I have a lot to improve on. I am even more happy to receive a message from you, I consider you one of the utopian's most demanding people, not that this is bad. Keep it up!

  • Elastic Search will return error by duplicate ID, but was to update the readme and make it more practical. The collector is just for picking up old issues.

  • My next update will cover all this part.

Thank you again.

Coin Marketplace

STEEM 0.19
TRX 0.25
JST 0.038
BTC 96742.26
ETH 3356.08
USDT 1.00
SBD 3.00