You are viewing a single comment's thread from:

RE: Contest Hero Development Update (Select Winners, Edit Contest, MongoDB and Express API)

in #utopian-io6 years ago

contesthero looks amazing, @tobias-g!

It has such a clear and minimalist design. I want to utilize it in the next couple of days.

A couple minor notes:

  • I see you keep /dist inside the repository. Are there any specific reason for that? It's a good practice to add /dist directories into .gitignore since they're auto-populated on the environment they run.

  • Adding/Editing contests has a couple replicated code (ex: getting images via regex, constructing the Comment operation). It might be good to make it reusable function and use it in seperate views for the maintenance in the future.


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thanks for the feedback, I really like the feedback I get from the development team, always a little thing I can improve on so it's very much appreciated.

In terms of your points:

  1. No reason, I was building it prior to pushing it Heroku previously however it's now built during deploy so no need for this now :), I will remove this in the next release.
  2. I agree I need to move a few features into a mixin so they're shared it's pretty annoying already and definitely wanted to get these sorted out in a release in the near future.

Once again thanks for the feedback :D

Thank you for your review, @emrebeyler!

So far this week you've reviewed 7 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.21
TRX 0.25
JST 0.038
BTC 95814.43
ETH 3337.94
USDT 1.00
SBD 3.10