You are viewing a single comment's thread from:
RE: Added new features to Blagominer: support for HTTPS connections and servers requiring custom headers
The Linux of Blockchain
looks like a very interesting catchword for a project. Interesting concept. I will have a look at Burstcoin.
Not an expert on the context, however, I can say that the post is decent quality.
As a side note, I see repeated commit messages. Squashing/Merging commits for such cases always creates a better GIT history. There is also a broken link on "get-rid-of-socket-leaks" link.
Looking forward to seeing more updates and development on blagominer :-)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review!
I've just corrected that link, thanks.
Regarding those duplicated commit messages (like "fixed socket leak") I actually deliberately kept that as separate commits, one per leak fixed. Small commits really help with conflict resolution later, and I tend to work on many branches. But you're totally right - I should include at least "where" (i.e. leak was in method xyz) and "case info" for given leak (leaks when it skips a test; leaks when it errors-out on response; etc). I'll keep that in mind in future.
"The Linux of Blockchain".. yeah.. I wish they took a bit less boasting catchword. BURST coin started out nice, then died, then was revived, then later it's flagship pools got huge amounts of bad reputation due to PoCC's war(?) with BHD coin.. BHD, as shady as it seems to be, and as ridiculous with its sky-high mortgaging requirements, actually defends its price and slowly shows up on new exchanges - that somewhat proves that there is some potential in Proof-of-Capacity, but time will evaluate that as always :)
Have a nice reading about all of that!
Thank you for your review, @emrebeyler! Keep up the good work!