You are viewing a single comment's thread from:

RE: Steem Smart Contracts: interaction via cutom json and transfer operations

in #utopian-io6 years ago (edited)

Thank you for your contribution. You are disallowing the console on this line
https://github.com/harpagon210/steemsmartcontracts/commit/35393c51be239d45eadb37ab259a1a6902f04214#diff-8e89c85f3650e78ec257a307fc4212f9R115, but I could not find any configuration of the same? Am I missing something?

Also in some places you are hardcoding some of the values like ssc, transfer,start block etc, can this be moved in a config file and then read it from there, because for example in the future if it changes you have to change everywhere wherever you are using it.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thanks for the review @codingdefined !

I disallowed the console because I figured out that it was logging too much unnecessary data... I should try to work on something that could allow/disallow the console debugging (an entry in the config file?)

I'll try to work on the hardcoded data to make everything a bit more flexible.

Thanks for the inputs, appreciate!

Thank you for your review, @codingdefined!

So far this week you've reviewed 12 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.22
TRX 0.26
JST 0.040
BTC 98411.40
ETH 3463.94
USDT 1.00
SBD 3.21