You are viewing a single comment's thread from:

RE: Global blacklist Checker tool build with Global blacklist API v2.0 -- Released

in #utopian-io6 years ago

It seems like a relatively interesting idea, but it's only really useful for people who have done something wrong (which resulted in them getting banned), so I'm not that sure about it.

As for the code itself, it doesn't seem like much work, is very simple, and even with its simplicity, the quality of the code is still quite poor. Some things you could improve:

  • Add some validation to the form. Only certain characters can be used in a username, can only be of a certain length etc. - you should take this into account.
  • The identation, or lack of identation, just makes the code hard to read. You can install a linter if you really can't be bothered to do it yourself.
  • Comments like echo $total; //print total blacklisted database aren't really necessary. Comments should be used to explain code that is difficult to understand.

I would also recommend you link the relevant commits and / or PRs in the body of your post, so we know what is part of the contribution (I used this commit). Good luck with future contributions, I am sure you can use this feedback to improve!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @amosbastian! Keep up the good work!

Coin Marketplace

STEEM 0.28
TRX 0.21
JST 0.039
BTC 96371.79
ETH 3682.82
SBD 3.84