You are viewing a single comment's thread from:

RE: UTmod: Introducing an extension for Utopian reviewers

in #utmod • 6 years ago

Thank you for your contribution @espoem! Nice piece of work and great initiatives!

  1. There are many chrome extension template generator for example this seems a good one.
  2. Next step is to publish in google webstore so it is easier for users to install the plugin - also, you might want to provide releases via tagging at here
  3. As you are using npm you might also want to configure the CI through https://travis-ci.com that will show a nice green build and passing if you have any unit tests.
  4. Your manifest.json contains unnecessary permissions for example unsafe-eval is not required as far as I can see from your code.
  5. Your popup.js should be related to the popup UI only and all other logics such as getReviewCommentBody could be better moved to a different module/file - which you can unit test if you do module.exports
  6. +1 for the real time final score as this is currently missing from https://review.utopian.io/ @amosbastian

Thanks! I will start using it next time!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Chat with us on Discord.

[utopian-moderator]

6 years ago in #utmod by
$15.74
  • Past Payouts $15.74
  • - Author $11.90
  • - Curators $3.85
22 votes
Reply 4
Sort:  
  • Trending
    • [-]
     6 years ago 

    Hey, thanks for the review. Some of the points may be useful for a later stage of development of the extension. Regarding unsafe-eval, I had issues in installing the extension locally while using webpack --watch as an error was raised in the browser and the js file could not be used otherwise.

    [-]
     6 years ago 

    you can remove unsafe-eval for production in that case.
    I actually setup 2 manifest.json, 1 is for development and 1 is for production

      process.env.NODE_ENV === 'production'
    ? [
        {
          from: path.resolve('src/manifest.production.json'),
          to: `${path.resolve('dist')}/manifest.json`,
        },
      ]
    : [
        {
          from: path.resolve('src/manifest.development.json'),
          to: `${path.resolve('dist')}/manifest.json`,
        },
      ];

    I written a vue.js based cli generator plugin, which will generate both files shown in here https://github.com/superoo7/vue-cli-plugin-chrome-ext/blob/8902ef6645045ade463b40dea132f92ac5b63615/generator/generate/manifest.js

    $0.00
      Reply
      [-]
       6 years ago 

      Thank you for your review, @justyy! Keep up the good work!

      $0.00
        Reply

        Coin Marketplace

        STEEM 0.20
        TRX 0.19
        JST 0.033
        BTC 88885.90
        ETH 3279.02
        USDT 1.00
        SBD 2.99