You are viewing a single comment's thread from:
RE: CLOSED: 125 STEEM Developer Bounty Inside [Python]
hi @felixxx,
The script looks like too messy to refactor. I can do a complete rewrite in 24 hours for a total 125 STEEM. What do you think about that? I am experienced w/ discord and steem api's.
Don't know enough Python but totally agree sometimes to clean up the mess takes a longer time than to redesign and rewrite the thing :-)
I agree, that it really is messy.
If you did a complete redesign, I'd like to plan ahead for some extra features.
I'll just wait for some more replies, to give others a chance - Hope that's ok.
No problem.
I have a couple of ideas:
Don't parse every block. Instead use get_account_history for each curator and filter only votes. Much more cleaner code and less overhead. This will remove almost half of the code.
Use mongodb to log already sent votes and check from there.
Use supervisord to restart the bot if bot goes down. Fixing the main reason is the real solution however you can always use Supervisord to auto-restart the process.
Custom node settings are not valid on some internal classes of steem-python. There are a couple of pull requests waiting for approval about this issue but they didn't do that yet. Using get_account_history with a custom list of nodes working well though. So, this won't be a o problem.
Let me know, if you decide for a rewrite.
my Discord id: emre#9263.
Another feature of the bot ( which now runs as a separate script ) is to drop a comment under posts, when the author has used #deutsch for the first time.
To integrate that I'd need to get all blocks.
Yes, you will need to listen then. However, I strongly suggest keeping them separate processes. Totally different things. For the sake of "seperation of concerns". They may exist in the same repository but I don't recommend same process.
For the welcome functionality:
$deutchebot --welcomeIt will listen all blocks and welcome users if they use the tag first time.
For the discord/curate functionality:
$deutchebot --curateIt will not listen all blocks, will work with get_account_history.
I understand, but ...
... I wanted both functions to broadcast to discord with the same bot ID :/
ah, if the "welcome bot" does something with the discord, it's okay. :)