RE: Introducing SteemData Notify
This is a great idea.
Unfortunately, it seems like it isn't working right now. I tried using it and haven't gotten a Telegram message confirming my settings even though I sent the correct memo to @null.
Looking through the code I found the likely issue. (Also please consider enabling Issues on the forked GitHub repo so there is an official place to submit these bugs. Furthermore, I noticed there is no license specified in either your repo or flowfree's repository from which it is forked.)
In this line of the code, you require that the memo be exactly 24 characters long, but the memo generated by the service is always 40 characters long.
I have also discovered another issue when experimenting with the service. I first saved settings with some set of options. Then I changed it again with another set of options. In both cases I am pretty sure they are still in an unconfirmed state in your database because of the above bug. But when I try to change the settings back to the earlier configuration, I get an internal server error. My guess is that it is because of this line. I believe it tries to insert a document with the exact same _id as a previously inserted document and that causes an error.
I think what it should do is if it finds an existing item with the same _id, it should first check to make sure that the _id does not match the _id field of find_user_settings(username) (i.e. you are not trying to set the settings to the currently active one), and if those _ids do not match then it should replace the existing found object in the database with the new one (most of the fields would of course be the same but it would have a newer created_at time and confirmed would be set to False). On the other hand if the _ids do exactly match, then it should return a user-friendly error message letting the user know that the settings they want to save are exactly already the currently active settings.
Finally, I think your service should warn users that their settings are completely public. Since they are potentially entering in email addresses and/or Telegram public channel links that could be used to find Telegram handles, it is important users are aware of this fact before entering in any data.
The bugs have been fixed.
As far as privacy goes, the server now sends garbled email/telegram id's.
I appreciate the time and effort you've put into catching bugs and making this report. Thank you @arhag.
I think that the service should never, under any condition expose emails or telegram handles, except for the first and last character. This means that the user would have to re-enter their email/telegram with each setting change. This minor inconvenience however is well worth the privacy.
Thanks for you contributio and observation. With people like you,steemit will survive
And the author of this post may God bless you. For trying to create a grate way of notification for we steemit users.
As for me below is the post about my believe for steemit.
https://steemit.com/steemit/@callistus/steemit-the-next-big-social-media-revolution
Wow, good looking out. This was a good article but the bug-checking and warnings you've provided have been at least as helpful as the article. These guys should be paying you hahaha. Thanks again!
very useful,,, thanks,,, follow me @musliadialasyi
Dang. That is a detailed follow-up comment
Well done
I think its' going to take me a while to understand this platform, but I find the information very useful and interesting
It is good Steemit has voluntary developers like you, @arhag, however if Steemit Inc doesn't stepup to do more of the development and management of Steemit, it might fall to a new potential killer > https://steemit.com/steemit/@blockrush/is-wildspark-the-steemit-killer-blockrush