You are viewing a single comment's thread from:
RE: OneLoveDTube IPFS Uploader v0.8.4: Keychain auth support, updated homepage and more!
Thank you for your contribution @techcoderx !
- It is better to use
===
instead of==
(!==
instead of!=
)in JS and==true
seems redudant. - Some parts of the JS code end with a semicolon but some do not.
- some
vars
could be replaced by eitherconst
orlet
. - The messages you are alert-ing in the JS code could be extracted in a JSON file so that you can internationalize them later.
- Unit Tests missing in the project - you could use
mocha
/chai
or other testing frameworks and set up the CI using travis-ci.com
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thank you for your review, @justyy! Keep up the good work!
Right on @justyy thank you for the feedback 💪
Posted using Partiko iOS