You are viewing a single comment's thread from:

RE: Lightsteem 0.0.7 - Account helper is arrived.

in #lightsteem6 years ago

Thank you for your contribution.

  1. It is interesting to see the benchmarking for performance. But I wonder how many test-runs have you carried out.
  2. I notice some code are quite the same for example here seems taken from here, it would be better to give a reference somewhere in your project.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

I notice some code are quite the same for example here seems taken from here, it would be better to give a reference somewhere in your project.

Yep, base58 module stands for transaction signing stuff which is mostly derived from steem-python. It's already written in the earlier announcement posts and related pull requests.

For example, beem has a similar base58.py and bitshares-python has the same, and goes on. Also steem-python's base58 module is based on cryptocoins project, etc.

However, also adding somewhere in the project would make sense since this is not the first time I hear that.

Thanks.

Thank you for your review, @justyy!

So far this week you've reviewed 1 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.14
TRX 0.24
JST 0.032
BTC 88555.94
ETH 2188.16
USDT 1.00
SBD 0.80