There is usually some great wisdom from people that have actually walked through things in their life.
I think every effort we put into our health has a long term effect. In some cases other instances may override that good....like in your case with smoking, but the other benefits will remain.
We will never regret doing good for our physical selves