Hardware wallet definitely the best for longer term holding but if you trade regularly you will need to leave coins on your exchange/s as its time consuming and costly to keep moving coins back and forth. I use a trezor having been burnt by bankrupt exchanges before.