Busy now supports 12 tags for SCOT tokens / est account value fix / multiple links bug fix

in #utopian-io5 years ago (edited)

Repository

https://github.com/busyorg/busy

1 new feature and 2 bug fixes

New Feature: 12 maximum tags support for SCOT tokens

PR: https://github.com/busyorg/busy/pull/2212

These days, there are so many Steem Engine SCOT tokens with Nitrous.

Nitrous already supports 10 tags, but Busy supported only up to 5 tags.
Now, Busy supports up to 12 (dozen sounded right to me :) tags.

Busy now supports more than 5 tags

but up to 12 tags

In fact, Steem API doesn't have a hard limit on this, but some API call may not work properly. (For instance, utopian posting queueing system doesn't work if you use more than 5 tags based on my experience. Of course, if you used more than 5 and then modified it with up to 5 tags, the post is registered.)

Code

  • Previously, the number 5 was hard-coded, which wasn't good.
  • So I defined the constant MAX_TAG for a potential change in the future
  • Intl message is also added. (translation will be done later, which can be done mechanically).

Bug Fix: Est. Account Value

PR: https://github.com/busyorg/busy/pull/2215

There was a month-old bug that doesn't show estimated account value due to SBD price fetching error. https://github.com/busyorg/busy/issues/2207

It was due to deprecated API use, so I made the following changes.

  • For SBD price, first try cryptosPriceHistory and then feed rate.
    cryptosPriceHistory doesn't support SBD prices for a long time, but just in case it supports again, I implemented the above logic.

  • Show Estimated Account Value (Previously it can't be shown due to no SBD price)

Code

Bug Fix: Multiple links support in one sentence

PR: https://github.com/busyorg/busy/pull/2198

Before

Previously there was a rendering bug that only the first link was rendered as a hyperlink, as below

e.g., https://busy.org/@blockchainstudio/steem-keychain-should-hide-private-keys-by-default

After

Now all links are shown properly.

Code

  • The problem was due to the misuse of linksRe instead of linksAny.

GitHub Account

https://github.com/economicstudio

Sort:  

Thank you for your contribution. Good to know that the Busy now supports more than 5 tags! I am sure all these contributions help improve the user experiences and just one comment, maybe you should remove the 'console.log' in the production environment.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Hi @justyy, thank you for your review. Actually console.log was already removed by another PR, but I didn't include it. Nice catch though :)

Thank you for your review, @justyy! Keep up the good work!

와우!! 블록체인스튜디오님이 손대셨으니 이제 비지의 눈부신 발전이 시작되겠군요~ ㅎㅎ
저는 요즘은 정말 이것저것 너무 하고싶은게 많아서 미칠지경입니다.. ㅋㅋ

미치면 안되죠. 하고 싶은것은 바로 바로 실행하십시오.

곰돌이가 @anpigon님의 소중한 댓글에 $0.005을 보팅해서 $0.018을 살려드리고 가요. 곰돌이가 지금까지 총 5821번 $63.843을 보팅해서 $74.723을 구했습니다. @gomdory 곰도뤼~

곰돌이가 @happyberrysboy님의 소중한 댓글에 $0.005을 보팅해서 $0.018을 살려드리고 가요. 곰돌이가 지금까지 총 5814번 $63.790을 보팅해서 $74.615을 구했습니다. @gomdory 곰도뤼~

Korean: 따로 포스팅했던 태그 개수 12개로 늘린 것 외에 자산가치 제대로 안나오던 것 수정했고 한문장에 링크 여러개일 경우 첫번째 링크만 링크가 걸리던 문제도 수정했습니다. 키체인 지원은 좀 시간을 두고 할 생각입니다.

그리고 태그 12개는 매우 환영합니다!! ㅋㅋㅋ

링크 오류 수정과 태그 제한이 풀렷네요. 감사합니다.

sct천사의 보팅입니다.
앞으로도 좋은 글 부탁드려요~~^^

Coin Marketplace

STEEM 0.22
TRX 0.26
JST 0.040
BTC 98648.57
ETH 3466.82
USDT 1.00
SBD 3.21