You are viewing a single comment's thread from:

RE: [KnackSteem] - Edit/Reply for Articles and Comments

in #utopian-io6 years ago

Thanx, that is great feedback! About redux action binding: I am actually using your suggestion in another project (with Next.js), so I know exactly what you mean and you are absolutely right. I also like the way how you avoid a separate mapStateToProps function by just putting it in the connect param in your screenshot. Still readable, but more compact.
About awaiting the dispatch: There´s some routing and other stuff involved, so while I agree that actions should handle success responses, in this case it´s a lot easier to just use async/await to wait for the dispatch to return. Although, put that into an action that does the routing or other stuff...will consider that for a refactoring session :)
Again, thanx for the valuable and detailed feedback!

Coin Marketplace

STEEM 0.25
TRX 0.20
JST 0.037
BTC 96295.92
ETH 3577.12
USDT 1.00
SBD 3.74